Messages in this thread | | | Date | Tue, 6 Oct 2009 17:19:00 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 2/3] perf trace: Update eval_flag() flags array to match interrupt.h |
| |
On Tue, Oct 06, 2009 at 09:27:32AM -0400, Christoph Hellwig wrote: > On Tue, Oct 06, 2009 at 01:00:48AM -0500, Tom Zanussi wrote: > > Add missing BLOCK_IOPOLL_SOFTIRQ entry. > > Nothing against your patch which is good for the short term, but the > existance of this code is a major design flaw. The trace events are > supposed to be self describing and having them duplicated in the trace > tool means either we're not using that self-description or it's not > good enough to be used. > > We'll soon add a lot more flags (e.g. my xfs tracing patch if I can ever > get the formal maintainer to review it will add various), and it was > also made pretty clear that perf while packaged with the kernel should > work independent of the actual kernel version, e.g. one perf binary > should work with older host kernels too which might have very different > flag values. >
Yeah. We may want to do that by including trace/events/irq.h and then use the show_softirq_name() macro defined there.
The rest of the header can be wrapped through no-op macros and stub includes.
| |