lkml.org 
[lkml]   [2009]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] pata_sc1200: Fix crash on boot
    Date
    The SC1200 needs a NULL terminator or it may cause a crash on boot.

    Bug #14227

    Also correct a bogus comment as the driver had serializing added so can run
    dual port.

    Signed-off-by: Alan Cox <alan@linux.intel.com>
    ---

    drivers/ata/pata_sc1200.c | 3 +--
    1 files changed, 1 insertions(+), 2 deletions(-)


    diff --git a/drivers/ata/pata_sc1200.c b/drivers/ata/pata_sc1200.c
    index f49814d..3bbed83 100644
    --- a/drivers/ata/pata_sc1200.c
    +++ b/drivers/ata/pata_sc1200.c
    @@ -235,8 +235,7 @@ static int sc1200_init_one(struct pci_dev *dev, const struct pci_device_id *id)
    .udma_mask = ATA_UDMA2,
    .port_ops = &sc1200_port_ops
    };
    - /* Can't enable port 2 yet, see top comments */
    - const struct ata_port_info *ppi[] = { &info, };
    + const struct ata_port_info *ppi[] = { &info, NULL };

    return ata_pci_sff_init_one(dev, ppi, &sc1200_sht, NULL);
    }


    \
     
     \ /
      Last update: 2009-10-06 17:21    [W:0.019 / U:58.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site