Messages in this thread |  | | | Subject | RE: [PATCH v3] mfd: ADP5520 Multifunction LCD Backlight and KeypadInput Device Driver | | Date | Tue, 6 Oct 2009 16:05:45 +0100 | | From | "Hennerich, Michael" <> |
| |
>From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] >On Tue, Oct 06, 2009 at 03:32:56PM +0100, Hennerich, Michael wrote: > >> This is not an interrupt controller. >> The only ADP5520 subdev that needs to be notified is the adp5520-keys >> input driver, if present. >> Sounds like overshoot, registering a irq_chip using >> set_irq_chip_and_handler() and friends, for exactly one dedicated and >> known consumer. > >According to the datasheet the GPIOs, light sensor and regulator can >also generate interrupts?
Right - I know - but none of the subdevs are currently using this functionality.
>The GPIOs in particular would benefit from >this since this would mean that their interrupts would be usable by >generic gpiolib based drivers.
Right - and I didn't say that I'm not going to add this functionality later. All the ADP5520 subdevs already merged in 2.6.32 - the MFD core is the only remaining part. Time is running short and major changes are going to require another round of full testing.
-Michael
|  |