Messages in this thread Patch in this message | | | From | KOSAKI Motohiro <> | Subject | [PATCH 2/2] mlock use lru_add_drain_all_async() | Date | Tue, 6 Oct 2009 11:41:25 +0900 (JST) |
| |
Recently, Peter Zijlstra reported RT-task can lead to prevent mlock very long time.
Suppose you have 2 cpus, cpu1 is busy doing a SCHED_FIFO-99 while(1), cpu0 does mlock()->lru_add_drain_all(), which does schedule_on_each_cpu(), which then waits for all cpus to complete the work. Except that cpu1, which is busy with the RT task, will never run keventd until the RT load goes away.
This is not so much an actual deadlock as a serious starvation case.
Actually, mlock() doesn't need to wait to finish lru_add_drain_all(). Thus, this patch replace it with lru_add_drain_all_async().
Cc: Oleg Nesterov <onestero@redhat.com> Reported-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- mm/mlock.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/mlock.c b/mm/mlock.c index 22041aa..46a016f 100644 --- a/mm/mlock.c +++ b/mm/mlock.c @@ -458,7 +458,7 @@ SYSCALL_DEFINE2(mlock, unsigned long, start, size_t, len) if (!can_do_mlock()) return -EPERM; - lru_add_drain_all(); /* flush pagevec */ + lru_add_drain_all_async(); /* flush pagevec */ down_write(¤t->mm->mmap_sem); len = PAGE_ALIGN(len + (start & ~PAGE_MASK)); @@ -526,7 +526,7 @@ SYSCALL_DEFINE1(mlockall, int, flags) if (!can_do_mlock()) goto out; - lru_add_drain_all(); /* flush pagevec */ + lru_add_drain_all_async(); /* flush pagevec */ down_write(¤t->mm->mmap_sem); -- 1.6.2.5
| |