Messages in this thread | | | Date | Mon, 5 Oct 2009 22:43:32 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH tracing/kprobes v2 4/5] perf: Add perf probe subcommand for kprobe-event setup helper |
| |
Em Mon, Oct 05, 2009 at 08:57:28PM -0400, Masami Hiramatsu escreveu: > Steven Rostedt wrote: > > On Fri, 2009-10-02 at 17:49 -0400, Masami Hiramatsu wrote: > >> diff --git a/tools/perf/Makefile b/tools/perf/Makefile > >> index b5f1953..6dabcf1 100644 > >> --- a/tools/perf/Makefile > >> +++ b/tools/perf/Makefile > >> @@ -419,6 +419,16 @@ ifneq ($(shell sh -c "(echo '\#include <libelf.h>'; echo 'int main(void) { Elf * > >> msg := $(error No libelf.h/libelf found, please install libelf-dev/elfutils-libelf-devel); > >> endif > >> > >> +ifneq ($(shell sh -c "(echo '\#include <libdwarf/dwarf.h>'; echo '\#include <libdwarf/libdwarf.h>'; echo 'int main(void) { Dwarf_Debug dbg; Dwarf_Error err; dwarf_init(0, DW_DLC_READ, 0, 0, &dbg, &err); return (long)dbg; }') | $(CC) -x c - $(ALL_CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -ldwarf -lelf -o /dev/null $(ALL_LDFLAGS) > /dev/null 2>&1 && echo y"), y) > >> + msg := $(warning No libdwarf.h found, disables probe subcommand. Please install libdwarf-dev/libdwarf-devel); > > > > Wow! And I thought my macros were ugly ;-) > > :-) > Maybe, would I better make a separate c file to check this? > Like "autoconf-checkdwarf.c".
I saw that coming, I'd say leave it as is... :)
> >> + > >> + /* Copy arguments */ > >> + pp->nr_args = argc - 2; > >> + if (pp->nr_args > 0) { > >> + pp->args = (char **)malloc(sizeof(char *) * pp->nr_args); > > > > Hmm, you don't check for failed malloc here? > > Oops...
Also no need for cast
- Arnaldo
| |