lkml.org 
[lkml]   [2009]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:core/urgent] panic: Fix panic message visibility by calling bust_spinlocks(0) before dying
    Commit-ID:  d014e8894dfc523dd9d2f2a17b6dcb94facea810
    Gitweb: http://git.kernel.org/tip/d014e8894dfc523dd9d2f2a17b6dcb94facea810
    Author: Aaro Koskinen <aaro.koskinen@nokia.com>
    AuthorDate: Fri, 2 Oct 2009 14:41:20 +0300
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Mon, 5 Oct 2009 21:08:09 +0200

    panic: Fix panic message visibility by calling bust_spinlocks(0) before dying

    Commit ffd71da4e3f ("panic: decrease oops_in_progress only after
    having done the panic") moved bust_spinlocks(0) to the end of the
    function, which in practice is never reached.

    As a result console_unblank() is not called, and on some systems
    the user may not see the panic message.

    Move it back up to before the unblanking.

    Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
    Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
    LKML-Reference: <1254483680-25578-1-git-send-email-aaro.koskinen@nokia.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>


    ---
    kernel/panic.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/kernel/panic.c b/kernel/panic.c
    index 512ab73..bc4dcb6 100644
    --- a/kernel/panic.c
    +++ b/kernel/panic.c
    @@ -90,6 +90,8 @@ NORET_TYPE void panic(const char * fmt, ...)

    atomic_notifier_call_chain(&panic_notifier_list, 0, buf);

    + bust_spinlocks(0);
    +
    if (!panic_blink)
    panic_blink = no_blink;

    @@ -136,7 +138,6 @@ NORET_TYPE void panic(const char * fmt, ...)
    mdelay(1);
    i++;
    }
    - bust_spinlocks(0);
    }

    EXPORT_SYMBOL(panic);

    \
     
     \ /
      Last update: 2009-10-05 21:21    [W:0.024 / U:126.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site