Messages in this thread | | | From | (Eric W. Biederman) | Date | Sun, 04 Oct 2009 16:39:22 -0700 | Subject | Re: [PATCH] USB: ftdi_sio: Remove tty->low_latency. |
| |
Johan Hovold <jhovold@gmail.com> writes:
>> > > > + * The per character mucking around with sysrq path it too slow, so >> > > > + * shortcircuit it in the 99.9999999% of cases where the USB serial is >> > > > + * not a console anyway. >> > > > + */ >> > > > + ch = packet + 2; >> > > > + len -= 2; >> > > > + if (!port->console || !port->sysrq) >> > > >> > > You need && flag == TTY_NORMAL ? >> > >> > You tell me. :-) Are we interested in them unless port->console is set? >> >> Yes - we don;t care about the sysrq but we care about error characters >> being reported ot the line discipline properly. > > Wasn't thinking.. Here's an update which always passes error characters. > It also uses ASYNCB_INITIALIZED (instead of ASYNCB_CLOSING) in unthrottle.
To test this what should I be applying this on top of? There have been a lot of patches flying around.
Eric
| |