lkml.org 
[lkml]   [2009]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] USB: ftdi_sio: Remove tty->low_latency.
Johan Hovold <jhovold@gmail.com> writes:

>> > > > + * The per character mucking around with sysrq path it too slow, so
>> > > > + * shortcircuit it in the 99.9999999% of cases where the USB serial is
>> > > > + * not a console anyway.
>> > > > + */
>> > > > + ch = packet + 2;
>> > > > + len -= 2;
>> > > > + if (!port->console || !port->sysrq)
>> > >
>> > > You need && flag == TTY_NORMAL ?
>> >
>> > You tell me. :-) Are we interested in them unless port->console is set?
>>
>> Yes - we don;t care about the sysrq but we care about error characters
>> being reported ot the line discipline properly.
>
> Wasn't thinking.. Here's an update which always passes error characters.
> It also uses ASYNCB_INITIALIZED (instead of ASYNCB_CLOSING) in unthrottle.

To test this what should I be applying this on top of?
There have been a lot of patches flying around.


Eric


\
 
 \ /
  Last update: 2009-10-05 01:45    [W:0.101 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site