Messages in this thread | | | Date | Sun, 4 Oct 2009 14:53:49 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] connector: Provide the sender's credentials to the callback |
| |
On Tue, 29 Sep 2009 16:48:09 +0200 Philipp Reisner <philipp.reisner@linbit.com> wrote:
> Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com> > Acked-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Please don't send unchangelogged patches.
The title tells us what the patch does, but how is the reader supposed to work out why it does it?
> diff --git a/drivers/md/dm-log-userspace-transfer.c b/drivers/md/dm-log-userspace-transfer.c > index ba0edad..556131f 100644 > --- a/drivers/md/dm-log-userspace-transfer.c > +++ b/drivers/md/dm-log-userspace-transfer.c > @@ -129,7 +129,7 @@ static int fill_pkg(struct cn_msg *msg, struct dm_ulog_request *tfr) > * This is the connector callback that delivers data > * that was sent from userspace. > */ > -static void cn_ulog_callback(void *data) > +static void cn_ulog_callback(void *data, struct netlink_skb_parms *nsp) > { > struct cn_msg *msg = (struct cn_msg *)data; > struct dm_ulog_request *tfr = (struct dm_ulog_request *)(msg + 1);
Your "connector/dm: Fixed a compilation warning" fix is already in linux-next, so we throw a small and easily-fixed reject here.
| |