lkml.org 
[lkml]   [2009]   [Oct]   [31]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 31 Oct 2009 20:54:28 +0530
From"Aneesh Kumar K.V" <>
SubjectRe: [Bug 14354] Re: ext4 increased intolerance to unclean shutdown?
On Sat, Oct 31, 2009 at 05:15:28AM -0400, Theodore Tso wrote:
> On Fri, Oct 30, 2009 at 01:56:27PM -0600, Andreas Dilger wrote:
> > I wonder if there are multiple problems involved here? Eric, it seems
> > possible that your reproducer is exercising a similar, though unrelated
> > codepath.
>
> Note that Aneesh has pubished two patches which insert a call to
> ext4_discard_preallocations(). One is a patch which inserts it into
> fs/inode.c's truncate path (for direct/indirect-mapped inodes) and one
> which is patch which inserts it into fs/extents.c truncate path (for
> extent-mapped inodes). As near as I can tell both patches are
> necessary, and it looks to me like they should be combined into a
> single patch, since commit 487caeef9 affects both truncate paths.
> Aneesh, do you concur?
>

We need only the patch that drop prealloc space in ext4_truncate_restart_trans
ext4_ext_truncate_extend_restart calls ext4_truncate_restart_trans. So adding
the prealloc space dropping in ext4_truncate_restart_trans should handle both
direct/indirect-mapped inode and extent-mapped inodes.

-aneesh


\
 
 \ /
  Last update: 2009-10-31 16:29    [W:0.242 / U:0.000 seconds]
©2003-2009 Jasper Spaans