Messages in this thread |  | | | Date | Sat, 31 Oct 2009 12:59:59 +0300 | | From | Cyrill Gorcunov <> | | Subject | Re: [PATCH] x86, apicdef: Fix checkpatch issues in apicdef.h |
| |
[Cyrill Gorcunov - Sat, Oct 31, 2009 at 12:44:31PM +0300] | [Rakib Mullick - Sat, Oct 31, 2009 at 03:29:32PM +0600] | | | | In apicdef.h - we have a checkpatch issue - needs to be fixed. | | We were warned by the following checkpatch warning: | | | | ERROR: space prohibited before that ':' (ctx:WxW) | | #276: FILE: arch/x86/include/asm/apicdef.h:376: | | + hi : 1; | | ^ | | --- | | Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com> | | | | Hi Rakib, | | personally I would not change it even having checkpatch | issue. Really, it's easier to read this bitfield width | aligned rather then moved left. But this is a personal | opinion only (sorry). | | -- Cyrill
On the other hands -- I wonder if we need this structure at all. Perhaps there was an idea to use it with suspend/resume actions? Ingo, Maciej, Yinghai?
-- Cyrill
|  |