lkml.org 
[lkml]   [2009]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [bisected] 2.6.31 regression sis5513 PIO Mode 0 hang
    On Fri, Oct 02, 2009 at 10:30:56PM -0700, - wrote:
    > Thank you for finding the problem. The kernel is way too complex
    > for someone who's not familiar with it (like me) to track these
    > things down.

    If you do a reverse apply on the patch, does it work for you? The
    below is already reversed, so apply it normally, or just open the file
    with an editor and comment out those lines.

    From 6029336426a2b43e4bc6f4a84be8789a047d139e Mon Sep 17 00:00:00 2001
    From: Joao Ramos <joao.ramos@inov.pt>
    Date: Sun, 17 May 2009 17:22:54 +0200
    Subject: [PATCH] ide: try to use PIO Mode 0 during probe if possible

    Initially set PIO Mode 0 for all host drivers that have a 'set_pio_mode'
    method before the IDE core figures out the most suited PIO mode for the
    attached device.

    Signed-off-by: Joao Ramos <joao.ramos@inov.pt>
    Cc: Sergei Shtylyov <sshtylyov@ru.montavista.com>
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    ---
    drivers/ide/ide-probe.c | 9 +++++++++
    1 files changed, 9 insertions(+), 0 deletions(-)

    diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
    index 7f264ed..b609a58 100644
    --- a/drivers/ide/ide-probe.c
    +++ b/drivers/ide/ide-probe.c
    @@ -1032,15 +1032,6 @@ static void ide_port_init_devices(ide_hwif_t *hwif)
    if (port_ops && port_ops->init_dev)
    port_ops->init_dev(drive);
    }
    -
    - ide_port_for_each_dev(i, drive, hwif) {
    - /*
    - * default to PIO Mode 0 before we figure out
    - * the most suited mode for the attached device
    - */
    - if (port_ops && port_ops->set_pio_mode)
    - port_ops->set_pio_mode(drive, 0);
    - }
    }

    static void ide_init_port(ide_hwif_t *hwif, unsigned int port,
    --
    1.5.6.5

    --
    David Fries <david@fries.net>
    http://fries.net/~david/ (PGP encryption key available)


    \
     
     \ /
      Last update: 2009-10-03 15:05    [W:0.023 / U:0.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site