Messages in this thread | | | From | Michael Buesch <> | Subject | Re: [PATCH RFC] isdn/capi: fix up CAPI subsystem workaround locking a bit | Date | Sat, 3 Oct 2009 20:26:22 +0200 |
| |
On Saturday 03 October 2009 14:06:57 Tilman Schmidt wrote: > Move calls to handle_minor_send() and handle_minor_recv() out of > the sections locked by workaround_lock. > - handle_minor_send() may call another CAPI function via the card > driver, deadlocking by trying to take workaround_lock again. > - handle_minor_recv() calls the receive_buf method of the active > line discipline which may sleep.
I remember that handle_minor_send() and/or handle_minor_recv() showed up in the crash backtraces. So if you move them out of the critical section, you can as well remove the lock completely.
-- Greetings, Michael.
| |