lkml.org 
[lkml]   [2009]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 1/7] m68knommu: Don't hardcode the value of PAGE_SIZE in the linker script.
    Hi Tim,

    This one gives me:

    arch/m68knommu/kernel/vmlinux.lds.S:19:1: warning: "BSS" redefined
    In file included from arch/m68knommu/kernel/vmlinux.lds.S:10:
    include/asm-generic/vmlinux.lds.h:495:1: warning: this is the location
    of the previous definition

    A define named "BSS" is already used inside of vmlinux.lds.S.
    No big deal, I just changed that internal one.

    But otherwise no problems with this patch.

    Regards
    Greg



    Tim Abbott wrote:
    > Signed-off-by: Tim Abbott <tabbott@ksplice.com>
    > ---
    > arch/m68knommu/kernel/vmlinux.lds.S | 5 +++--
    > 1 files changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/arch/m68knommu/kernel/vmlinux.lds.S b/arch/m68knommu/kernel/vmlinux.lds.S
    > index 2736a5e..edc20bd 100644
    > --- a/arch/m68knommu/kernel/vmlinux.lds.S
    > +++ b/arch/m68knommu/kernel/vmlinux.lds.S
    > @@ -8,6 +8,7 @@
    > */
    >
    > #include <asm-generic/vmlinux.lds.h>
    > +#include <asm/page.h>
    >
    > #if defined(CONFIG_RAMKERNEL)
    > #define RAM_START CONFIG_KERNELBASE
    > @@ -155,7 +156,7 @@ SECTIONS {
    > } > DATA
    >
    > .init : {
    > - . = ALIGN(4096);
    > + . = ALIGN(PAGE_SIZE);
    > __init_begin = .;
    > _sinittext = .;
    > INIT_TEXT
    > @@ -180,7 +181,7 @@ SECTIONS {
    > *(.init.ramfs)
    > __initramfs_end = .;
    > #endif
    > - . = ALIGN(4096);
    > + . = ALIGN(PAGE_SIZE);
    > __init_end = .;
    > } > INIT
    >

    --
    ------------------------------------------------------------------------
    Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
    SnapGear Group, McAfee PHONE: +61 7 3435 2888
    825 Stanley St, FAX: +61 7 3891 3630
    Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com


    \
     
     \ /
      Last update: 2009-10-30 02:01    [W:0.028 / U:0.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site