lkml.org 
[lkml]   [2009]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/3][RFC] tracing/kprobes: prevent jprobes from crashing function graph tracer
From
Date
On Thu, 2009-10-29 at 19:22 -0400, Masami Hiramatsu wrote:
> Steven Rostedt wrote:

> >> I think we can skip those user handlers, because those are irregular
> >> functions and user can control (enable/disable) it.
> >
> > True, but it may be nice to still trace them.
>
> Hm, in that case, I think we can change jprobe_return() to call
> f-g-tracer's return handler if needed as below;
> ---
> static inline jprobe_return(void)
> {
> implicit_function_return(); /* This executes f-g-tracer prologue */
> __jprobe_return(); /* This should be notraced */
> }

Hmm, That looks like it can be quite a hack. We don't know at that
moment if the handler has been traced or not. We can't always do the
function graph logic.

-- Steve




\
 
 \ /
  Last update: 2009-10-30 01:09    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site