Messages in this thread | | | Date | Thu, 29 Oct 2009 10:19:08 -0600 | From | Matthew Wilcox <> | Subject | Re: [PATCH 1/3] Fix updating of named attribute groups |
| |
On Thu, Oct 29, 2009 at 04:59:02PM +0100, Tejun Heo wrote: > Matthew Wilcox wrote: > > + if (update) { > > + sd = sysfs_get_dirent(kobj->sd, grp->name); > > + if (!sd) > > + return -ENOENT; > > + } else { > > + error = sysfs_create_subdir(kobj, grp->name, &sd); > > + if (error) > > + return error; > > + sysfs_get(sd); > > + } > > + } else { > > + sd = sysfs_get(kobj->sd); > > + } > > nitpick: the last braces aren't necessary.
But are more aesthetically pleasing.
-- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
| |