lkml.org 
[lkml]   [2009]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/6] [resend] thermal: improvements re. forced passive cooling
Date
Hi Andrew,

On Wednesday 28 October 2009, Andrew Morton wrote:
> I'm trying to work out what the actual bug is in here.

It turned out there was no bug in the kernel. This patch set is an
enhancement of existing kernel functionality.

> afacit some KDE tool put wrong numbers into /proc files, acpi didn't
> sanity check them sufficiently and permitted the CPU to overheat, yes?

No. The problem was that the thermal zone that overheated did not have a
passive trip point defined in ACPI. So the kernel had no way of knowing
the system was overheating.

The kernel already has an option to "force" a passive trip point for such
zones (using polling to check it), and that works. But while testing that
and looking at the code I spotted some possible enhancements.

> There seems to be rather a lot of non-bugfix stuff in this patch
> series. Perhaps too much for 2.6.32, and a real problem if we want to
> backport something into 2.6.31.x and earlier.

It would have been nice if it had made .32 from my first submission, but
now it's fine for .33. It's not stable material.

Thanks for taking the series.

Cheers,
FJP


\
 
 \ /
  Last update: 2009-10-28 23:51    [W:0.109 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site