lkml.org 
[lkml]   [2009]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] PM / Hibernate: fix error handling in save_image
Date
On Saturday 10 October 2009, Pavel Machek wrote:
> On Sat 2009-10-10 13:51:45, Jiri Slaby wrote:
> > There are too many retval variables in save_image. Thus error return
> > value from snapshot_read_next may be ignored and only part of the
> > snapshot (successfully) written.
> >
> > Remove 'error' variable, invert the condition in the do-while loop
> > and convert the loop to use only 'ret' variable.
> >
> > Switch the rest of the function to consider only 'ret'.
> >
> > Also make sure we end printed line by \n if an error occurs.
> >
> > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> ACK.

Applied to suspend-2.6/linux-next.

Thanks,
Rafael


\
 
 \ /
  Last update: 2009-10-28 23:09    [W:0.049 / U:1.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site