Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 1/1] PM / Hibernate: fix error handling in save_image | Date | Wed, 28 Oct 2009 23:08:04 +0100 |
| |
On Saturday 10 October 2009, Pavel Machek wrote: > On Sat 2009-10-10 13:51:45, Jiri Slaby wrote: > > There are too many retval variables in save_image. Thus error return > > value from snapshot_read_next may be ignored and only part of the > > snapshot (successfully) written. > > > > Remove 'error' variable, invert the condition in the do-while loop > > and convert the loop to use only 'ret' variable. > > > > Switch the rest of the function to consider only 'ret'. > > > > Also make sure we end printed line by \n if an error occurs. > > > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > > ACK.
Applied to suspend-2.6/linux-next.
Thanks, Rafael
| |