Messages in this thread | | | Date | Wed, 28 Oct 2009 17:35:34 +0100 | From | Borislav Petkov <> | Subject | [RFC] amd64_edac: syndromes loading |
| |
Hi,
I've been pondering how to avoid adding almost 15K of syndrome tables to the edac driver.
The syndrome tables are used for mapping a correctable ECC to the corresponding DIMM and thus pinpointing the DIMM about to fail. There are two flavors of syndromes based on the ECCs: x4 and x8. The x4 table of size 540 u16 values is already in the driver but the x8 is much bigger (4864 u16) and I wouldn't want to add it statically into the driver.
Rather, I'd like to dynamically load them depending on the DRAM configuration of each node. The two attached patches do that using the request_firmware() interface. This way, the syndrome tables could be added as binary blobs in drivers/edac/ and then installed with 'make firmware_install'. This way we avoid polluting driver code with humongous u16 arrays of ECC syndromes.
What do you guys think, could that be an acceptable approach? Any suggestions/comments are welcome.
Thanks.
-- Regards/Gruss, Boris.
Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München (OSRC) | Registergericht München, HRB Nr. 43632
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |