lkml.org 
[lkml]   [2009]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateTue, 27 Oct 2009 10:32:47 -0700
FromGreg KH <>
SubjectRe: [PATCH 3/3] Expose MSI-X interrupts through a dynamically generated sysfs directory
On Tue, Oct 20, 2009 at 02:26:02AM -0600, Matthew Wilcox wrote:
> On Tue, Oct 20, 2009 at 04:14:44PM +0800, Am??rico Wang wrote:
> > On Tue, Oct 20, 2009 at 1:50 PM, Matthew Wilcox <matthew@wil.cx> wrote:
> > > +#define kobj_to_pci_dev(obj) to_pci_dev(container_of(obj, struct device, kobj))
> >
> > You define this, but no one uses it?
>
> Yeah, left over from an earlier version of the patch. Thanks, I'll
> remove it.
>
> > > + ?? ?? ?? array = kmalloc((nr_irqs + 1) * sizeof(void *), GFP_KERNEL);
> > > + ?? ?? ?? if (!array)
> > > + ?? ?? ?? ?? ?? ?? ?? return -ENOMEM;
> > > + ?? ?? ?? attr = kmalloc(nr_irqs * sizeof(*attr), GFP_KERNEL);
> > > + ?? ?? ?? if (!attr)
> > > + ?? ?? ?? ?? ?? ?? ?? return -ENOMEM;
> >
> > Here leaks memory allocated above.
>
> Oh, yeah, duh, thanks.

Care to resend this series with these fixes?

thanks,

greg k-h


\
 
 \ /
  Last update: 2009-10-27 19:01    [from the cache]
©2003-2010