[lkml]   [2009]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] vfs: Add a trace point in the mark_inode_dirty function
    On Sun, Oct 25, 2009 at 10:53:42PM -0700, Arjan van de Ven wrote:
    > diff --git a/include/trace/events/vfs.h b/include/trace/events/vfs.h
    > new file mode 100644
    > index 0000000..21cf9fb
    > --- /dev/null
    > +++ b/include/trace/events/vfs.h
    > @@ -0,0 +1,53 @@
    > +#undef TRACE_SYSTEM
    > +#define TRACE_SYSTEM vfs
    > +
    > +#if !defined(_TRACE_VFS_H) || defined(TRACE_HEADER_MULTI_READ)
    > +#define _TRACE_VFS_H
    > +
    > +/*
    > + * Tracepoint for dirtying an inode:
    > + */


    I would like to see us add docbook style comments for each added trace
    event. I've already started a docbook for this, and written comments for
    the irq tracepoints, in include/trace/events/irq.h. The docbook can be
    viewed at:

    I think there has been some talk that the documentation should be
    included as part of the kernel, so that 'perf' can easily access this. I
    don't see how these docbook style comments wouldn't help with that
    effort as well. We already have scripts to parse these comments, and it
    probably wouldn't be hard to extend them to create a binary version, if
    needed. Further, as your above comment indicates, these types of
    comments want to be included in the source code above the TRACE_EVENTS

    The initial lkml postings were:




     \ /
      Last update: 2009-10-27 17:05    [W:0.023 / U:4.268 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site