Messages in this thread | | | Date | Tue, 27 Oct 2009 14:04:07 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/2] percpu: allow pcpu_alloc() to be called with IRQs off |
| |
* Tejun Heo <tj@kernel.org> wrote:
> Jiri Kosina wrote: > > pcpu_alloc() and pcpu_extend_area_map() perform a series of > > spin_lock_irq()/spin_unlock_irq() calls, which make them unsafe > > with respect to being called from contexts which have IRQs off. > > > > This patch converts the code to perform save/restore of flags instead, > > making pcpu_alloc() (or __alloc_percpu() respectively) to be called > > from early kernel startup stage, where IRQs are off. > > > > This is needed for proper initialization of per-cpu rq_weight data from > > sched_init(). > > > > Signed-off-by: Jiri Kosina <jkosina@suse.cz> > > Acked-by: Tejun Heo <tj@kernel.org> > > I'll wait for response on the series and push it through percpu#fixes > tomorrow if there's no objection.
Yep, the 2/2 sched.c patch looks good now:
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
| |