lkml.org 
[lkml]   [2009]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH] oom_kill: avoid depends on total_vm and use real RSS/swap value for oom_score (Re: Memory overcommit
    On Tue, Oct 27, 2009 at 04:56:12PM +0900, Minchan Kim wrote:
    > Thanks for making the patch.
    > Let's hear other's opinion. :)

    total_vm is nearly meaningless, especially on 64bit that reduces the
    mmap load on libs, I tried to change it to something "physical" (rss,
    didn't add swap too) some time ago too, not sure why I didn't manage
    to get it in. Trying again surely sounds good. Accounting swap isn't
    necessarily good, we may be killing a task that isn't accessing memory
    at all. So yes, we free swap but if the task is the "bloater" it's
    unlikely to be all in swap as it did all recent activity that lead to
    the oom. So I'm unsure if swap is good to account here, but surely I
    ack to replace virtual with rss. I would include the whole rss, as the
    file one may also be rendered unswappable if it is accessed in a loop
    refreshing the young bit all the time.


    \
     
     \ /
      Last update: 2009-10-27 13:41    [W:4.101 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site