Messages in this thread | | | Date | Mon, 26 Oct 2009 11:12:30 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH 1/1] crash_dump: fix non-pae kdump kernel memory accesses |
| |
On 10/25/2009 05:20 PM, Ingo Molnar wrote: >> +#ifndef CONFIG_X86_PAE >> +/* non-PAE kdump kernel executed from a PAE one will crop high pte bits and >> + poke unwanted space counting again from address 0, we don't want that */ >> +static inline bool is_crashed_pfn_valid(unsigned long pfn) >> +{ >> + /* on non-PAE pte must fit into unsigned long >> + in fact the test is (pfn & 0x000fffff) */ >> + return pte_pfn(pfn_pte(pfn, __pgprot(0))) == pfn; >> +} >> +#else >> +static inline bool is_crashed_pfn_valid(unsigned long pfn) { return true; } >> +#endif > > i'd suggest to push the #ifdef inside the function.
I posted a v2 patch a second ago. Thanks.
| |