lkml.org 
[lkml]   [2009]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC V2 PATCH 5/5] cfq-iosched: fairness for sync no-idle queues
Date
Corrado Zoccolo <czoccolo@gmail.com> writes:

> +static enum wl_type_t cfqq_type(struct cfq_queue *cfqq)
> +{
> + if (!cfq_cfqq_sync(cfqq))
> + return ASYNC_WORKLOAD;
> + if (CFQQ_SEEKY(cfqq) || !cfq_cfqq_idle_window(cfqq))
> + return SYNC_NOIDLE_WORKLOAD;
> + return SYNC_WORKLOAD;
> +}

The calculation to determine whether or not to idle is now done in at
least 2 places. Perhaps it's time for a helper function.

There are some other coding style nits, but I'll let Jens comment on
those. I think the idea looks good. Once you rebase I'll run some
tests; this is some really good work!

Cheers,
Jeff


\
 
 \ /
  Last update: 2009-10-26 16:49    [W:0.042 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site