Messages in this thread | | | Date | Mon, 26 Oct 2009 16:37:19 +0100 | From | Simon Kagstrom <> | Subject | Re: [PATCH v11 4/5] core: Add kernel message dumper to call on oopses and panics |
| |
On Mon, 26 Oct 2009 17:13:27 +0200 "Shargorodsky Atal (EXT-Teleca/Helsinki)" <ext-atal.shargorodsky@nokia.com> wrote:
> How about adding KMSG_DUMP_LAST_OOPS_BEFORE_PANIC or something to the > kmsg_dump_reason enum, and making the kmsg_dump look like > kmsg_dump(panic_on_oops ? KMSG_DUMP_LAST_OOPS_BEFORE_PANIC : KMSG_DUMP_OOPS); > in oops_exit. Then let the dumpers decide what they want to do about it. > Just a thought.
It would also have to take in_interrupt() in account since that will also lead to a panic.
> And since you have no objections about moving notifiers up, it looks > like the second issue will be resolved, I believe Artem > will take care of it. :)
Well, I have no objections to it, but I also know very little of the reasoning to put it there in the first place, so don't count my vote for very much here :-)
// Simon
| |