lkml.org 
[lkml]   [2009]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/7] ark3116: (3rd try) Replace cmget
Date
Am Sonntag, 25. Oktober 2009 18:51:00 schrieb bart.hartgers@gmail.com:
> +       /* read modem status */
> +       unsigned status = atomic_read(&priv->msr);
> +       /* modem control is output */
> +       unsigned ctrl = atomic_read(&priv->mcr);

What is the sense of having two atomic variables?
You can get races where one is changed but the other is not.

Regards
Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-10-25 20:53    [W:0.194 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site