Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH 3/7] ark3116: (3rd try) Replace cmget | Date | Sun, 25 Oct 2009 20:52:08 +0100 |
| |
Am Sonntag, 25. Oktober 2009 18:51:00 schrieb bart.hartgers@gmail.com: > + /* read modem status */ > + unsigned status = atomic_read(&priv->msr); > + /* modem control is output */ > + unsigned ctrl = atomic_read(&priv->mcr);
What is the sense of having two atomic variables? You can get races where one is changed but the other is not.
Regards Oliver
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |