Messages in this thread |  | | | Date | Mon, 26 Oct 2009 10:44:39 +0800 | | From | Franko Fang <> | | Subject | Re: PATCH 23/10]Optimize the upload speed for PPP connection. |
| |
Thanks your advice.
But generally, PAGE_SIZE is 4096, whether it is too large or not?
If PAGE_SIZE is really appropriate, then I can resubmit the patch.
Thanks very much. ----- Original Message ----- From: "David Miller" <davem@davemloft.net> To: <william.allen.simpson@gmail.com> Cc: <huananhu@huawei.com>; <netdev@vger.kernel.org>; <linux-kernel@vger.kernel.org>; <zihan@huawei.com>; <greg@kroah.com>; <haegar@sdinet.de> Sent: Saturday, October 24, 2009 9:46 PM Subject: Re: PATCH 23/10]Optimize the upload speed for PPP connection.
> From: William Allen Simpson <william.allen.simpson@gmail.com> > Date: Fri, 23 Oct 2009 07:46:08 -0400 > >> Concur. I'd go further than that, my code usually made room for at >> least >> a full MTU (MRU) with HDLC escaping. To minimize context switches, >> that >> should be 3014 ((1500 MRU + 2 FCS + 4 header) * 2 escapes + 2 flags). >> >> Even in the old days, when memory was tight, context switches and >> interrupt >> time were more expensive, too. PPP is supposed to scale to OC-192. > > Actually I'd like to see ->obuf allocated externally and then > make it simply PAGE_SIZE. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
|  |