lkml.org 
[lkml]   [2009]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/9] ser_gigaset: checkpatch cleanup
Alan Cox schrieb:

>> - if (!(bcs->tx_skb = skb_dequeue(&bcs->squeue)))
>> + nextskb = skb_dequeue(&bcs->squeue);
>> + if (!nextskb)
>> /* no skb either, nothing to do */
>> return;
>> + bcs->tx_skb = nextskb;
>
> This does not do the same thing as before
>
> Previously the NULL case assigned to bcs->tx_skb, now it does not.

bcs->tx_skb is guaranteed to be NULL already at this point because
of the enclosing "if (!bcs->tx_skb)".

Thanks,
Tilman

--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2009-10-26 00:39    [W:1.242 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site