Messages in this thread | | | Date | Sun, 25 Oct 2009 02:48:31 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 0/7] kfifo: new API v0.6 |
| |
On Sat, Oct 24, 2009 at 03:33:14PM +0200, Stefani Seibold wrote: > This is a new generic kernel FIFO implementation. > > The current kernel fifo API is not very widely used, because it has to many > constrains. Only 17 files in the current 2.6.31-rc5 used it. FIFO's are > like list's a very basic thing and a kfifo API which handles the most use > case would save a lot of development time and memory resources. > > I think this are the reasons why kfifo is not in use: > > - The API is to simple, important functions are missing > - A fifo can be only allocated dynamically > - There is a need of a spinlock despite you need it or not > - There is no support for data records inside a fifo
I have some plans to use this kfifo code in upcoming code (mostly as a very simple lower overhead NMI safe per CPU fifo). I would appreciate if it could be merged ASAP
I didn't review this iteration, but earlier ones.
Acked-by: Andi Kleen <ak@linux.intel.com>
-Andi
| |