lkml.org 
[lkml]   [2009]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] tracefs
From
Date
On Fri, 2009-10-23 at 07:32 +0200, Ingo Molnar wrote:

> _No way_ do we want to tie down the pretty-printing ftrace details as an
> ABI. We promised that when ftrace went upstream and all the details are
> way too messy to be exposed in an ABI alike matter (and yes, consider
> this a NAK Steve ;-).

Note, I wasn't talking about tie down the pretty-print formats. But we
need to have a standard way to change them.

For example:

[root@mxf ~]# cat /debug/tracing/events/power/power_start/format
name: power_start
ID: 258
format:
field:unsigned short common_type; offset:0; size:2;
field:unsigned char common_flags; offset:2; size:1;
field:unsigned char common_preempt_count; offset:3; size:1;
field:int common_pid; offset:4; size:4;
field:int common_lock_depth; offset:8; size:4;

field:u64 type; offset:16; size:8;
field:u64 state; offset:24; size:8;

print fmt: "type=%lu state=%lu", (unsigned long)REC->type, (unsigned long)REC->state


Now we are going to add a "signed" field to each line. Fine, but we need
a spec of some sort to say how that will happen. Or what can be expected
to not change. We can say the type (field in this case) will always be
the first item, and that the type will stay on a single line. If the
parser does not know how to handle one of the items (offset, size, etc)
it can simply ignore it. When it hits the "\n", it is done with that
type.

We need to document this, so tools will not break when we update this
format.

-- Steve




\
 
 \ /
  Last update: 2009-10-23 15:15    [W:0.097 / U:0.712 seconds]
©2003-2011 Jasper Spaans. Advertise on this site