lkml.org 
[lkml]   [2009]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf timechart: Use pr_debug to report unknown header types
Arnaldo Carvalho de Melo wrote:
> Em Fri, Oct 23, 2009 at 10:55:39AM -0700, Arjan van de Ven escreveu:
>> Arnaldo Carvalho de Melo wrote:
>>> It was using eprintf that checked if verbose was !zero, when I converted
>>> to pr_*() I made the mistake of changing it to pr_warning which caused
>>> 'perf timechart' output to be way too verbose.
>>>
>> nack...
>>
>> if you EVER hit one of these you have a very very serious problem.
>> hiding that is never the right thing to do. I should make this a fatal
>> event instead.
>
> OK, so I actually fixed a bug as those messages weren't being noticed if
> -v wasn't used! :-)
>
> Please take a look at latest tip to see all those messages.
>
> - Arnaldo

I'm pretty sure latest -tip broke timechart; Frederic tends to have a habit of doing so occasionally :)



\
 
 \ /
  Last update: 2009-10-23 20:41    [W:0.626 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site