lkml.org 
[lkml]   [2009]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] dmi_check_system can generate Warnings when no DMI table is present
    From
    Date
    On Fri, 2009-10-23 at 17:03 +0200, Erwan Velu wrote:
    > Daniel Walker a écrit :
    > > [...]
    > > It's your defect, so you can still try to fix it (unless the "xen
    > > people" or someone else beats you to it.)
    > >
    > > It looks like on a normal system dmi_scan_machine() gets called very
    > > early in setup_arch() arch/x86/kernel/setup.c . A possible good fix
    > > might be to add a dmi_disable() into the dmi driver that just shuts off
    > > dmi, and run that in xen_arch_setup() in arch/x86/xen/setup.c
    > Could it make sense having this patch (I can work on it) while keeping
    > my previous patch ?
    > Does it make sense keeping the default return value I've been adding
    > when no dmi table is found ?

    Ingo mentioned that the returning mechanism your adding was left out
    intentionally to catch this error, so I don't think your original patch
    could be included ..

    Daniel

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-10-23 17:13    [W:0.021 / U:60.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site