lkml.org 
[lkml]   [2009]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] net: Adjust softirq raising in __napi_schedule
    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA1

    Johannes Berg schrieb:
    > On Wed, 2009-10-21 at 23:39 +0200, Jarek Poplawski wrote:
    >
    >> I'm not sure I can understand your question. This patch is mainly to
    >> avoid using netif_rx()/netif_rx_ni() pair as a test of proper process
    >> context handling; IMHO there're better tools for this (lockdep,
    >> WARN_ON's).
    >
    > I'm saying that it seems to me, as indicated by the API (and without
    > proof otherwise that's how it is) the networking layer needs to have
    > packets handed to it with softirqs disabled.

    Strange. Then what are the two separate functions netif_rx() and
    netif_rx_ni() for?

    > This really should be obvious. You're fixing the warning at the source
    > of the warning, rather than the source of the problem.

    Good idea. So please do tell us where the source of the problem is.

    Thanks,
    Tilman

    - --
    Tilman Schmidt E-Mail: tilman@imap.cc
    Bonn, Germany
    Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
    Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.4 (MingW32)
    Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

    iD8DBQFK4cALQ3+did9BuFsRAnW8AKCP4ey+gT2RZBYpzx91PaXd11A/PwCgh35g
    fhEbJs++1BRIQ3encV8fIm4=
    =SSaA
    -----END PGP SIGNATURE-----
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-10-23 16:41    [W:0.041 / U:0.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site