Messages in this thread Patch in this message | | | Subject | [PATCH v2 2/5] mm: refactor register_cpu_under_node() | From | Alex Chiang <> | Date | Wed, 21 Oct 2009 22:15:15 -0600 |
| |
By returning early if the node is not online, we can unindent the interesting code by one level.
No functional change.
Signed-off-by: Alex Chiang <achiang@hp.com> ---
drivers/base/node.c | 20 +++++++++++--------- 1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/base/node.c b/drivers/base/node.c index 3108b21..ef7dd22 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -227,16 +227,18 @@ struct node node_devices[MAX_NUMNODES]; */ int register_cpu_under_node(unsigned int cpu, unsigned int nid) { - if (node_online(nid)) { - struct sys_device *obj = get_cpu_sysdev(cpu); - if (!obj) - return 0; - return sysfs_create_link(&node_devices[nid].sysdev.kobj, - &obj->kobj, - kobject_name(&obj->kobj)); - } + struct sys_device *obj; - return 0; + if (!node_online(nid)) + return 0; + + obj = get_cpu_sysdev(cpu); + if (!obj) + return 0; + + return sysfs_create_link(&node_devices[nid].sysdev.kobj, + &obj->kobj, + kobject_name(&obj->kobj)); } int unregister_cpu_under_node(unsigned int cpu, unsigned int nid)
| |