lkml.org 
[lkml]   [2009]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC][v8][PATCH 0/10] Implement clone3() system call
    From
    Date
    Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> writes:

    > Eric W. Biederman [ebiederm@xmission.com] wrote:
    > | +static int set_pidmap(struct pid_namespace *pid_ns, int target)
    > | +{
    > | + if (target >= pid_max)
    > | + return -1;
    >
    > I am changing this and the next return to 'return -EINVAL', to match
    > an earlier patch in my patchset.
    >
    > | + if (target < RESERVED_PIDS)
    >
    > Should we replace RESERVED_PIDS with 0 ? We currently allow new
    > containers to have pids 1..32K in the first pass and in subsequent
    > passes assign starting at RESERVED_PIDS.

    If it is a preexisting namespace pid namespace removing the RESERVED_PIDS
    check removes most if not all of the point of RESERVED_PIDS.

    In a new fresh pid namespace I have no problem with not performing
    the RESERVED_PIDS check.

    So I guess that makes the check.

    if ((target < RESERVED_PIDS) && pid_ns->last_pid >= RESERVED_PIDS)
    return -EINVAL;

    Eric


    \
     
     \ /
      Last update: 2009-10-23 03:07    [W:0.021 / U:31.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site