lkml.org 
[lkml]   [2009]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH -v4 9/9] tracing: add function graph tracer support for MIPS
    From
    Date

    FYI:

    One of the comments made at the kernel summit, was to have people trim
    email when sending. It makes it a lot easier to reply then to scroll
    down lots of lines of quoted text just to read something that only
    references part of the email.

    Don't be afraid to cut out quoted text. It does help (as I did in this
    reply).

    On Fri, 2009-10-23 at 01:39 +0800, Wu Zhangjin wrote:

    > > > .set reorder
    > > > diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S
    > > > index 162b299..f25df73 100644
    > > > --- a/arch/mips/kernel/vmlinux.lds.S
    > > > +++ b/arch/mips/kernel/vmlinux.lds.S
    > > > @@ -46,6 +46,7 @@ SECTIONS
    > > > SCHED_TEXT
    > > > LOCK_TEXT
    > > > KPROBES_TEXT
    > > > + IRQENTRY_TEXT
    > >
    > > This looks like it should be in a separate patch. I don't see where you
    > > explain this?
    > >
    >
    > This is used to fix this error:
    >
    > kernel/built-in.o: In function `print_graph_irq':
    > trace_functions_graph.c:(.text+0x82f40): undefined reference to
    > `__irqentry_text_start'
    > trace_functions_graph.c:(.text+0x82f48): undefined reference to
    > `__irqentry_text_start'
    > trace_functions_graph.c:(.text+0x82f70): undefined reference to
    > `__irqentry_text_end'
    > trace_functions_graph.c:(.text+0x82f74): undefined reference to
    > `__irqentry_text_end'

    Right, and this should be in a separate patch, showing this error in the
    change log.

    Thanks,

    -- Steve




    \
     
     \ /
      Last update: 2009-10-22 20:01    [W:0.028 / U:0.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site