lkml.org 
[lkml]   [2009]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] page allocator: Do not allow interrupts to use ALLOC_HARDER
    On Thu, 22 Oct 2009 15:22:33 +0100
    Mel Gorman <mel@csn.ul.ie> wrote:

    > Commit 341ce06f69abfafa31b9468410a13dbd60e2b237 altered watermark logic
    > slightly by allowing rt_tasks that are handling an interrupt to set
    > ALLOC_HARDER. This patch brings the watermark logic more in line with
    > 2.6.30.
    >
    > [rientjes@google.com: Spotted the problem]
    > Signed-off-by: Mel Gorman <mel@csn.ul.ie>
    > Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
    > ---
    > mm/page_alloc.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
    > index dfa4362..7f2aa3e 100644
    > --- a/mm/page_alloc.c
    > +++ b/mm/page_alloc.c
    > @@ -1769,7 +1769,7 @@ gfp_to_alloc_flags(gfp_t gfp_mask)
    > * See also cpuset_zone_allowed() comment in kernel/cpuset.c.
    > */
    > alloc_flags &= ~ALLOC_CPUSET;
    > - } else if (unlikely(rt_task(p)))
    > + } else if (unlikely(rt_task(p)) && !in_interrupt())
    > alloc_flags |= ALLOC_HARDER;
    >
    > if (likely(!(gfp_mask & __GFP_NOMEMALLOC))) {
    > --
    > 1.6.3.3
    >

    Is it correct that this one applies offset -54 lines in 2.6.31.4 ?

    --
    Regards,
    Stephan


    \
     
     \ /
      Last update: 2009-10-22 18:35    [W:0.023 / U:214.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site