lkml.org 
[lkml]   [2009]   [Oct]   [22]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 22 Oct 2009 14:17:18 -0200
FromMarcelo Tosatti <>
SubjectRe: [PATCH] virtio-pci: fix per-vq MSI-X request logic
On Thu, Oct 22, 2009 at 03:06:06PM +0200, Michael S. Tsirkin wrote:
> Commit f68d24082e22ccee3077d11aeb6dc5354f0ca7f1
> in 2.6.32-rc1 broke requesting IRQs for per-VQ MSI-X vectors:
> - vector number was used instead of the vector itself
> - we try to request an IRQ for VQ which does not
> have a callback handler
>
> This is a regression that causes warnings in kernel log,
> potentially lower performance as we need to scan vq list,
> and might cause system failure if the interrupt
> requested is in fact needed by another system.
>
> This was not noticed earlier because in most cases
> we were falling back on shared interrupt for all vqs.

Works for me. Thanks Michael.

Tested-by: Marcelo Tosatti <mtosatti@redhat.com>


\
 
 \ /
  Last update: 2009-10-22 18:23    [from the cache]
©2003-2009