Messages in this thread | | | Date | Wed, 21 Oct 2009 13:52:59 +0200 | From | Ingo Molnar <> | Subject | Re: [RFC Patch] use MTRR for write combining if PAT is not available |
| |
* Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> On Tue, 2009-10-20 at 13:35 -0700, Thomas Schlichter wrote: > > What do you think about the latest version of my patch series I just sent? > > I think we can simplify this by just using mtrr_add_page() and avoid > all the complexity that comes with mtrr_add_unaligned(). > > pci_mmap_range() should call one mtrr_add_page() if the base and size > are nicely aligned. Almost all the cases, this is the usage sequence > here anyway.
yep, keeping it simple is a must.
Ingo
| |