Messages in this thread |  | | | From | Eric Miao <> | | Date | Thu, 22 Oct 2009 04:20:34 +0800 | | Subject | Re: spitz backlight: fix brightness limiting |
| |
It's a little bit weird it's called 'limit_mask' when I first converted it to a spi driver. There must be some reasons, Richard, you've got any ideas?
On Tue, Oct 20, 2009 at 5:37 AM, Pavel Machek <pavel@ucw.cz> wrote: > > On spitz (& similar) machines, if battery is running low, backlight > needs to be limited to lower step. Unfortunately, current code uses &= > for limiting, turning backlight off completely for some backlight > settings. Fix that. > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > --- linux-rc/drivers/video/backlight/corgi_lcd.c 2009-10-18 18:11:36.000000000 +0200 > +++ linux-rc/drivers/video/backlight/corgi_lcd.c 2009-10-16 02:10:13.000000000 +0200 > @@ -433,8 +434,9 @@ > > if (corgibl_flags & CORGIBL_SUSPENDED) > intensity = 0; > - if (corgibl_flags & CORGIBL_BATTLOW) > - intensity &= lcd->limit_mask; > + > + if ((corgibl_flags & CORGIBL_BATTLOW) && intensity > lcd->limit_mask) > + intensity = lcd->limit_mask; > > return corgi_bl_set_intensity(lcd, intensity); > } > > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |