Messages in this thread | | | Date | Tue, 20 Oct 2009 08:51:08 +0200 (CEST) | From | Michael Schmitz <> | Subject | Re: Fwd: [PATCH] [RFC] ataflop: remove buggy IRQ disable from do_fd_request() |
| |
Hi Jiri,
> > > Please elaborate a little bit more which of the two points above you base > > > your NACK on. > > > > The removal of local_irq_disable() (which should have been local_irq_enable()) > > just raised a flag, and I didn't immediately see why the interrupt enable had > > been commented out. > > Yes, it has been commented out in a very non-intuitive way.
That. too :-) What I meant to say - the reason why someone chose to comment out the original sti() wasn't really clear. I guess the reason for that particular change has been lost in the pre-git or bk era.
> > With a bit of further thought on the matter I am satisfied that this patch will > > not impact on driver function at all, and do not wish to sustain my objection. > > > > IOW: Ack, and my sincere apologies for wasting your time. > > Thanks, I have added > > Acked-by: Michael Schmitz <schmitz@biophys.uni-duesseldorf.de> > > to the patch changelog in my tree.
That's right ...
Michael
| |