Messages in this thread | | | Date | Fri, 02 Oct 2009 13:41:10 +0530 | From | Suresh Jayaraman <> | Subject | Re: [PATCH 03/31] mm: expose gfp_to_alloc_flags() |
| |
David Rientjes wrote: > On Thu, 1 Oct 2009, Suresh Jayaraman wrote: > >> From: Peter Zijlstra <a.p.zijlstra@chello.nl> >> >> Expose the gfp to alloc_flags mapping, so we can use it in other parts >> of the vm. >> >> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> >> Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de> > > Nack, these flags are internal to the page allocator and exporting them to > generic VM code is unnecessary.
Yes, you're right.
> The only bit you actually use in your patchset is ALLOC_NO_WATERMARKS to > determine whether a particular allocation can use memory reserves. I'd > suggest adding a bool function that returns whether the current context is > given access to reserves including your new __GFP_MEMALLOC flag and > exporting that instead.
Makes sense and Neil already posted a patch citing the suggested changes, will incorporate the change.
Thanks,
-- Suresh Jayaraman
| |