Messages in this thread | | | Date | Fri, 2 Oct 2009 16:32:41 -0400 (EDT) | From | Tim Abbott <> | Subject | Re: [PATCH 2/2] arm: Clean up linker script using new linker script macros. |
| |
On Thu, 1 Oct 2009, Russell King - ARM Linux wrote:
> On Wed, Sep 30, 2009 at 11:39:25PM +0200, Sam Ravnborg wrote: > > > > Where is _end in the new layout? > > I think we lost it. > > You're right - this will cause a build failure since _end is used in > several core ARM files. Tim?
It's supposed to be after BSS_SECTION. I'll send you a new pair of patches with this fixed and Sam's acks added shortly.
> PS, please ensure that all patches are at the very least build tested, > or say when they aren't.
These were build-tested originally; it seems I introduced this bug when rebasing the patch past the recent DISCARD changes, and failed to retest. Sorry about that (I think you are right that it was more generally a mistake to not clearly tag these patches as build-but-not-run tested in the first place. I'll do that in the future).
My cross-compile environment is unavailable at present, so the new version will be completely untested as well.
-Tim Abbott
| |