lkml.org 
[lkml]   [2009]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] scripts/get_maintainer.pl: Add patch/file search for keywords
From
Date
On Mon, 2009-10-19 at 11:41 +0200, Wolfram Sang wrote:
> > @@ -149,6 +153,8 @@ while (<MAINT>) {
> > if ((-d $value)) {
> > $value =~ s@([^/])$@$1/@;
> > }
> > + } elsif ($type eq "K") {
> > + $keyword_hash{@typevalue} = $value;
>
> It matches the way how the current implementation works, but I guess somewhen
> this @typevalue-array should be converted into a hash like
> $types{$type} = $value;
> or similar unless I missed something.

I think you missed something.

What this is doing is saving the typevalue index of the
section where the keyword is specified. That index is
used on the type match to add maintainers.

> Maybe the file should be read completely to save the loop.

I see if that matters.

> A bit unrelated: I noticed that lkml gets always added due to "F: *". Maybe
> this list should be skipped if there has been another mailing list found?

I think that get_maintainers is generally used by people
that aren't already sure who should get an email about
a patch or file. I think lkml should be cc'd in almost
every case when someone is not already sure where to
send something.

cheers, Joe



\
 
 \ /
  Last update: 2009-10-19 17:49    [W:0.053 / U:0.076 seconds]
©2003-2014 Jasper Spaans. Advertise on this site