Messages in this thread | | | Date | Fri, 16 Oct 2009 19:43:20 +0900 | Subject | Re: BUG? linux-mips flush_dcache_page | From | Minchan Kim <> |
| |
On Fri, Oct 16, 2009 at 6:24 PM, Ralf Baechle <ralf@linux-mips.org> wrote: > On Fri, Oct 16, 2009 at 02:17:19PM +0900, Minchan Kim wrote: > >> Many code of kernel fs usually allocate high page and flush. >> But flush_dcache_page of mips checks PageHighMem to avoid flush >> so that data consistency is broken, I think. > > What processor and cache configuration?
Chungki. Could you anwer this question ?
>> I found it's by you and Atsushi-san on 585fa724. >> Why do we need the check? >> Could you elaborte please? > > The if statement exists because __flush_dcache_page would crash if a page > is not mapped. This of course isn't correct but that wasn't a problem > since highmem still is only supported on machines that don't have aliases.
Thansk for good explanation. Chungki. Please let us know your machine(processor and cache configuration)
> > Ralf >
-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |