lkml.org 
[lkml]   [2009]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[01/46] SCSI: Retry ADD_TO_MLQUEUE return value for EH commands
    2.6.31-stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Hannes Reinecke <hare@suse.de>

    commit 6e883b0e42739aa560133cfaf41be1138c51a500 upstream.

    A target reset when I/O is ongoing might result
    an eventual device offline, as scsi_eh_completed_normally()
    might return ADD_TO_MLQUEUE in addition to the
    advertised SUCCESS, FAILED, and NEEDS_RETRY.

    Which is unfortunate as scsi_send_eh_cmnd() will
    therefore map ADD_TO_MLQUEUE to FAILED instead of
    the more appropriate NEEDS_RETRY.

    Signed-off-by: Hannes Reinecke <hare@suse.de>
    Signed-off-by: James Bottomley <James.Bottomley@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/scsi/scsi_error.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/scsi/scsi_error.c
    +++ b/drivers/scsi/scsi_error.c
    @@ -721,6 +721,9 @@ static int scsi_send_eh_cmnd(struct scsi
    case NEEDS_RETRY:
    case FAILED:
    break;
    + case ADD_TO_MLQUEUE:
    + rtn = NEEDS_RETRY;
    + break;
    default:
    rtn = FAILED;
    break;



    \
     
     \ /
      Last update: 2009-10-16 19:21    [W:0.019 / U:3.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site