Messages in this thread |  | | | Date | Fri, 16 Oct 2009 10:10:31 +1100 | | From | Nigel Cunningham <> | | Subject | Re: [PATCH 1/9] swap_info: private to swapfile.c |
| |
Hi Hugh.
Hugh Dickins wrote: > The swap_info_struct is mostly private to mm/swapfile.c, with only > one other in-tree user: get_swap_bio(). Adjust its interface to > map_swap_page(), so that we can then remove get_swap_info_struct(). > > But there is a popular user out-of-tree, TuxOnIce: so leave the > declaration of swap_info_struct in linux/swap.h.
Sorry for the delay in replying.
I don't mind if you don't leave swap_info_struct in include/linux/swap.h. I'm currently reworking my swap support anyway, adding support for honouring the priority field. I've also recently learned that under some circumstances, allocating all available swap can take quite a while (I have a user who is hibernating with 32GB of RAM!), so I've been thinking about what I can do to optimise that. Regards,
Nigel
|  |