Messages in this thread | | | Subject | Re: [PATCH 12/13] [PATCH 12/13] perf tools: handle - and + in parsing trace print format | From | Steven Rostedt <> | Date | Thu, 15 Oct 2009 05:20:51 -0400 |
| |
On Thu, 2009-10-15 at 09:05 +0200, Peter Zijlstra wrote: > On Thu, 2009-10-15 at 08:42 +0200, Ingo Molnar wrote: > > > > -CFLAGS = $(M64) -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -fstack-protector-all -D_FORTIFY_SOURCE=2 $(EXTRA_WARNINGS) > > > +CFLAGS = $(M64) -ggdb3 -Wall -Wextra -std=gnu99 -Werror -fstack-protector-all -D_FORTIFY_SOURCE=2 $(EXTRA_WARNINGS) > > > > hm, why does this patch change the Makefile? > > > > i've skipped this hunk, it does not appear to be connected to the > > commit. > > Probably because he wanted to debug things and O6 generates crappy gdb > experience.. and then it slipped into the diff
Yeah, that's exactly what happened. Damn, I thought I put the -O6 back. This patch, I originally just did the '-', and thought. Hmm, it is trivial to do the '+'. So I added it and did a "git commit -a --amend", forgetting that I modified the Makefile.
This hunk can be ignored.
Thanks!
-- Steve
| |