Messages in this thread | | | Subject | Re: [PATCH] 8250_pci: Add IBM Saturn serial card | From | Benjamin Herrenschmidt <> | Date | Thu, 15 Oct 2009 08:01:36 +1100 |
| |
On Wed, 2009-10-14 at 12:48 +0100, Alan Cox wrote: > On Wed, 14 Oct 2009 10:40:53 +1100 > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > > > The IBM Saturn serial card has only one port. Without that fixup, > > the kernel thinks it has two, which confuses userland setup and > > admin tools as well. > > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > Looks good to me but can you drop a space between the last DEVICE_ID and > the VENDOR_ID bit in the header to follow the style ?
Ok. It was between the last IBM device ID and the IBM subvendor, I wasn't sure if that warranted a blank line :-)
I'll send a new patch from work.
Cheers, Ben.
| |