lkml.org 
[lkml]   [2009]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:bkl/drivers] drivers: Remove BKL from misc_open
On Wed, 14 Oct 2009 18:16:58 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:

> on Wed, 14 Oct 2009, Alan Cox wrote:
> > On Wed, 14 Oct 2009 15:47:39 GMT
> > tip-bot for Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > > Commit-ID: 40b798efe3460797a4ac928ee2e038774e2758eb
> > > Gitweb: http://git.kernel.org/tip/40b798efe3460797a4ac928ee2e038774e2758eb
> > > Author: Thomas Gleixner <tglx@linutronix.de>
> > > AuthorDate: Sat, 10 Oct 2009 15:35:43 +0000
> > > Committer: Thomas Gleixner <tglx@linutronix.de>
> > > CommitDate: Wed, 14 Oct 2009 17:33:32 +0200
> > >
> > > drivers: Remove BKL from misc_open
> > >
> > > misc_open() is already serialized with misc_mtx. Remove the BKL
> > > locking which got there via the BKL pushdown.
> >
> > NAK.
> >
> > You can't simply assume the mutex is enough - you have to either push it
> > down or review *every* possible called point below the lock_kernel take.
> >
> > In this case the open method of the misc devices below sometimes uses the
> > BKL.
>
> The BKL got pushed down into the open methods of misc dev users and we
> do not need to take it twice in a row, right ?

Then the comment is misleading and you need to document that you've
already pushed the BKL down into each user and checked them.

Alan


\
 
 \ /
  Last update: 2009-10-14 20:19    [W:0.190 / U:2.984 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site